Skip to content

fix(agent): ephemeral-storage on gke autopilot and slim enabled #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix(agent): ephemeral-storage on gke autopilot and slim enabled #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61373b7
fix: remove slim check on gke autopilot for ephemeral-storage
francesco-furlan Dec 6, 2023
a68817a
chore: bump charts versions
francesco-furlan Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/agent/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ sources:
- https://app.sysdigcloud.com/#/settings/user
- https://github.com/draios/sysdig
type: application
version: 1.18.0
version: 1.18.1
2 changes: 1 addition & 1 deletion charts/agent/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Sysdig Agent resources
{{- toYaml .Values.resources -}}
{{- else if not (hasKey $resourceProfiles .Values.resourceProfile) }}
{{- fail (printf "Invalid value for resourceProfile provided: %s" .Values.resourceProfile) }}
{{- else if and (include "agent.gke.autopilot" .) (not .Values.slim.enabled) }}
{{- else if include "agent.gke.autopilot" . }}
{{- toYaml (dict "requests" (dict "cpu" "250m"
"ephemeral-storage" .Values.gke.ephemeralStorage
"memory" "512Mi")
Expand Down
4 changes: 0 additions & 4 deletions charts/agent/tests/gke_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ tests:
gke:
autopilot: true
createPriorityClass: true
slim:
enabled: false
asserts:
- containsDocument:
kind: DaemonSet
Expand All @@ -31,8 +29,6 @@ tests:
autopilot: true
createPriorityClass: true
ephemeralStorage: 256Mi
slim:
enabled: false
asserts:
- equal:
path: spec.template.spec.containers[0].resources.requests.ephemeral-storage
Expand Down
4 changes: 2 additions & 2 deletions charts/sysdig-deploy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sysdig-deploy
description: A chart with various Sysdig components for Kubernetes
type: application
version: 1.33.0
version: 1.33.1
maintainers:
- name: AlbertoBarba
email: alberto.barba@sysdig.com
Expand All @@ -26,7 +26,7 @@ dependencies:
- name: agent
# repository: https://charts.sysdig.com
repository: file://../agent
version: ~1.18.0
version: ~1.18.1
alias: agent
condition: agent.enabled
- name: common
Expand Down