Skip to content

Conversation

@hayk99
Copy link
Contributor

@hayk99 hayk99 commented Dec 19, 2023

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@aroberts87 aroberts87 changed the title add vm scanners as team chore(registry-scanner): add vm scanners as team Dec 19, 2023
@github-actions github-actions bot dismissed their stale review December 19, 2023 14:56

All good!

Copy link
Contributor

@guidobonomi guidobonomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hayk99 hayk99 enabled auto-merge (squash) December 20, 2023 15:12
@hayk99 hayk99 merged commit 18f355a into master Dec 20, 2023
@hayk99 hayk99 deleted the git-add-team branch December 20, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants