fix(agent): properly render security block content #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There had been an issue where if the user set the agent.secure.enabled flag to true in the charts, any custom data in agent.sysdig.settings.security would not be properly rendered. This change addresses the issue by inspecting agent.sysdig.settings for any security block content when the rest of the Sysdig Secure items are being computed.
aroberts87
force-pushed
the
smagent-6410-secure-block-malformat
branch
from
18533f5 to
658c845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There had been an issue where if the user set the
agent.secure.enabledflag to true in the charts, any custom data inagent.sysdig.settings.securitywould not be properly rendered. This change addresses the issue by inspectingagent.sysdig.settingsfor any security block content when the rest of the Sysdig Secure items are being computed.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.