Skip to content

Conversation

@IvanNik
Copy link
Collaborator

@IvanNik IvanNik commented Apr 28, 2025

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@IvanNik IvanNik requested a review from a team as a code owner April 28, 2025 18:55
@IvanNik IvanNik marked this pull request as draft April 28, 2025 19:23
@IvanNik IvanNik force-pushed the feat/shield/netsec_secure_light branch from 3e49d6e to ec01061 Compare April 28, 2025 19:39
Copy link
Collaborator

@aroberts87 aroberts87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good approach, but you need to correct the helper function prefix (agent --> shield) and then the location of the image tag in the values (host.image.tag instead of image.tag).

@IvanNik IvanNik requested a review from aroberts87 April 28, 2025 21:16
@IvanNik
Copy link
Collaborator Author

IvanNik commented Apr 30, 2025

waiting for 13.9.0 agent release

@IvanNik IvanNik force-pushed the feat/shield/netsec_secure_light branch from c930a67 to 4962add Compare April 30, 2025 20:52
@IvanNik IvanNik marked this pull request as ready for review April 30, 2025 20:52
@IvanNik IvanNik requested a review from aroberts87 May 1, 2025 13:50
@IvanNik IvanNik merged commit 2a3f2d2 into main May 1, 2025
4 checks passed
@IvanNik IvanNik deleted the feat/shield/netsec_secure_light branch May 1, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants