Skip to content

fix(response actions): Add necessary permissions for jobs and replicasets #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix(response actions): Add necessary permissions for jobs and replicasets #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/shield/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ maintainers:
- name: mavimo
email: marcovito.moscaritolo@sysdig.com
type: application
version: 1.15.0
version: 1.15.1
appVersion: "1.0.0"
23 changes: 23 additions & 0 deletions charts/shield/templates/cluster/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,13 @@ rules:
{{- end }}

{{- if eq "true" (include "cluster.response_actions.isolate_network.enabled" .) }}
- apiGroups:
- batch
resources:
- jobs
verbs:
- get # needed to identify the pods to isolate

- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -281,12 +288,20 @@ rules:
{{- end }}

{{- if eq "true" (include "cluster.response_actions.get_logs.enabled" .) }}
- apiGroups:
- batch
resources:
- jobs
verbs:
- get # needed to identify the pods to get logs from

- apiGroups:
- apps
resources:
- daemonsets
- deployments
- statefulsets
- replicasets
verbs:
- get # needed to identify the pods to get logs from

Expand All @@ -306,12 +321,20 @@ rules:
{{- end }}

{{- if eq "true" (include "cluster.response_actions.volume_snapshot.enabled" .) }}
- apiGroups:
- batch
resources:
- jobs
verbs:
- get # needed to identify the pods with PVCs

- apiGroups:
- apps
resources:
- daemonsets
- deployments
- statefulsets
- replicasets
verbs:
- get # needed to identify the pods with PVCs

Expand Down
12 changes: 12 additions & 0 deletions charts/shield/tests/cluster/clusterrole_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,15 @@ tests:
of: ClusterRole
- isAPIVersion:
of: rbac.authorization.k8s.io/v1
- contains:
path: rules
content:
apiGroups:
- batch
resources:
- jobs
verbs:
- get
- contains:
path: rules
content:
Expand Down Expand Up @@ -536,6 +545,7 @@ tests:
- daemonsets
- deployments
- statefulsets
- replicasets
verbs:
- get
- contains:
Expand Down Expand Up @@ -566,6 +576,7 @@ tests:
- daemonsets
- deployments
- statefulsets
- replicasets
verbs:
- get
- contains:
Expand Down Expand Up @@ -595,6 +606,7 @@ tests:
- daemonsets
- deployments
- statefulsets
- replicasets
verbs:
- get
- contains:
Expand Down
Loading