Skip to content

Conversation

@monica-m-ps
Copy link
Collaborator

@monica-m-ps monica-m-ps commented Aug 7, 2025

What this PR does / why we need it:

https://sysdig.atlassian.net/browse/DOC-5090 We need to add examples as comments for app checks.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@monica-m-ps monica-m-ps self-assigned this Aug 7, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests

@monica-m-ps monica-m-ps changed the title fix(app-checks-example) DOC-5090 - Add App Checks example as comments docs(app-checks-example) DOC-5090 - Add App Checks example as comments Aug 7, 2025
@monica-m-ps monica-m-ps marked this pull request as ready for review August 7, 2025 16:48
@monica-m-ps monica-m-ps requested a review from a team as a code owner August 7, 2025 16:48
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests

@aroberts87 aroberts87 changed the title docs(app-checks-example) DOC-5090 - Add App Checks example as comments docs(agent): Add App Checks example as comments Aug 7, 2025
@github-actions github-actions bot dismissed their stale review August 7, 2025 17:02

All good!

@monica-m-ps monica-m-ps merged commit 1f47808 into main Aug 7, 2025
7 checks passed
@monica-m-ps monica-m-ps deleted the DOC-5090-add-app-check-example branch August 7, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants