fix(scan): respect global evaluation result for accepted risks #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in v6.2.0 where the action would fail even if all risks were accepted and the global policy evaluation passed.
The
ScanResultdomain entity was incorrectly recalculating the final evaluation result based on the outcome of individual policies, ignoring the global evaluation result provided in the scanner's report.This was wrong because the accepted risk at the level of an image is not reflected in the policy evaluations.
This caused the action to fail when
stop-on-failed-policy-evalwas set totrue.This has been fixed by:
globalEvaluationfrom the report directly in theScanResult.Fixes #92