-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add support for skip TLS verification #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Alejandro Magallón Soler <alejandro.magallon@sysdig.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for skipping TLS verification when connecting to the Sysdig API, useful for environments with self-signed certificates (e.g., on-premises deployments). The implementation introduces a new configuration option controlled via the SYSDIG_MCP_API_SKIP_TLS_VERIFICATION environment variable.
Key changes:
- Added
SkipTLSVerificationboolean configuration field with environment variable support - Refactored client initialization to support both
RequestEditorFnandClientOptiontypes through a newIntoClientOptioninterface - Added comprehensive test coverage for TLS verification behavior and invalid boolean environment variable handling
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.nix | Version bump from 0.5.4 to 0.6.0 |
| go.mod | Go version update from 1.25.2 to 1.25.5 |
| internal/config/config.go | Added SkipTLSVerification field and made getEnv generic to handle boolean parsing |
| internal/config/config_test.go | Added test cases for the new TLS verification configuration |
| internal/infra/sysdig/client.go | Introduced IntoClientOption interface to support mixed option types |
| internal/infra/sysdig/client_test.go | Added TLS verification tests with self-signed certificate scenarios |
| cmd/server/main.go | Implemented custom HTTP client with InsecureSkipVerify when configured |
| README.md | Documented the new SYSDIG_MCP_API_SKIP_TLS_VERIFICATION environment variable |
| docs/TROUBLESHOOTING.md | Added troubleshooting entry for certificate authority errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c7fce9 to
d415cd9
Compare
d415cd9 to
39ee402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.