feat(cloud_logs): add SNS support #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzo-merici
force-pushed
the
feat-cloudtrail-sns-ingestion-support
branch
from
48e49c2 to
2d0b91d
Compare
|
Should we be pinning minimum required sysdig provider version (in versions.tf) for the data sources being accessed? |
|
@ravinadhruve10 yes we tested this e2e, involving frontend as well |
ravinadhruve10
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the cloud-logs module to enhance AWS CloudTrail and Sysdig Secure integration by adding support for SNS Notifications