[pull] main from janlelis:main #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to calculate the width of such strings, it would previously crash with either `Encoding::InvalidByteSequenceError` or `Encoding::UndefinedConversionError`. Totally invalid characters are now simply replaced with a replacement character when converting to UTF8. Especially binary encoded strings (i.e. no encoding) don't make much sense but at least it doesn't crash now and tries to return a sensible default (assume the string is actually valid UTF8
Handle invalid encoded strings
- Fix that modifiers were ignored when not part of a larger sequence #29 - Only check for valid base characters when in Emoji level is RGI - Improve docs and specs
It's a simple function and I believe the result is not supposed to change at runtime.
Strings were not frozen, so it made a bunch of useless allocations too.
I found this method while benchmarking, which was unexpected.
Some basic numbers:
```
# frozen_string_literal: true
require 'unicode/display_width'
require 'benchmark/ips'
Benchmark.ips do |x|
x.report do
Unicode::DisplayWidth.of("foo")
end
x.compare!
end
```
Old gives `207.779k` iterations per second, while new one is `427.344k`.
So more than 2x faster for basic cases
Memoize `EmojiSupport.recommended`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )