Fix the "upgrade" GitHub Action #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syslog-ng/syslog-ng#4755 added a `name` keyword that cause confusion for our simle script. Ensure we are processing an actual `{"name": "string"}` and not somthing like `{"name": {...}}` to find keywords.
smortex
force-pushed
the
fix-upgrade-action
branch
from
e403f14 to
c2ed2e8
Compare
The diff mainly consist in a single long line of keywords where new keywords are added and old keywords may be removed. Reviewing this is a pain. Generate a readable diff in the PR body for easily spotting issues.
smortex
force-pushed
the
fix-upgrade-action
branch
from
69fe2d7 to
ae1a649
Compare
Collaborator
Author
|
Seems good now, see #13. |
Collaborator
|
Ah, now I understand which new option caused the problem: "options": {
"name": {
"name": "name",
"params": [
[
"<string>"
]
]
},
"metadata-url": {
"name": "metadata-url",
"params": [
[
"<string>"
]
]
},
"": {
"name": null,
"params": [
[
"<empty>"
]
]
}
}I think the db is correct, and we incorrectly assumed that a key-value pair with the key Your fix is perfect, thank you! |
alltilla
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10