Skip to content

Refactor error handling #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Refactor error handling #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,26 +488,21 @@ static int __init kxo_init(void)
ret = device_create_file(kxo_dev, &dev_attr_kxo_state);
if (ret < 0) {
printk(KERN_ERR "failed to create sysfs file kxo_state\n");
goto error_cdev;
goto error_device;
}

/* Allocate fast circular buffer */
fast_buf.buf = vmalloc(PAGE_SIZE);
if (!fast_buf.buf) {
device_destroy(kxo_class, dev_id);
class_destroy(kxo_class);
ret = -ENOMEM;
goto error_cdev;
goto error_vmalloc;
}

/* Create the workqueue */
kxo_workqueue = alloc_workqueue("kxod", WQ_UNBOUND, WQ_MAX_ACTIVE);
if (!kxo_workqueue) {
vfree(fast_buf.buf);
device_destroy(kxo_class, dev_id);
class_destroy(kxo_class);
ret = -ENOMEM;
goto error_cdev;
goto error_workqueue;
}

negamax_init();
Expand All @@ -527,6 +522,12 @@ static int __init kxo_init(void)
pr_info("kxo: registered new kxo device: %d,%d\n", major, 0);
out:
return ret;
error_workqueue:
vfree(fast_buf.buf);
error_vmalloc:
device_destroy(kxo_class, dev_id);
error_device:
class_destroy(kxo_class);
error_cdev:
cdev_del(&kxo_cdev);
error_region:
Expand Down