Fix false positive alarm in split_block() helper #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The split_block() helper incorrectly triggered a panic when the requested size matched the block size. Adjust the condition to avoid the false positive alarm.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Thank @vicLin8712 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
commit 44eed33
The
split_block()helper could incorrectly trigger a kernel panic when the requested allocation size was exactly equal to the current memory block size.Fix
Refer to PR #21
Adjusted the condition check in
split_block()to properly handle equal-size requests, preventing false positive panic conditions.Summary by cubic
Fix false panic in split_block() when the requested size equals the block size. Change the check from >= to > so exact-size requests no longer trigger ERR_HEAP_CORRUPT.