Consolidate all compositing primitive ops #133
Merged
+336
−225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a self-contained built-in renderer implementation. Extract 3 essential screen compositing functions (rgb16_source_argb32, argb32_over_argb32, argb32_source_argb32) to screen-ops.c, which is always compiled regardless of renderer choice. - Eliminate ~97.5% of unnecessary compositing code in PIXMAN mode - Improve naming consistency following draw-*.c pattern - Clear separation between renderer implementations
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a self-contained built-in renderer implementation. Extract 3 essential screen compositing functions (rgb16_source_argb32, argb32_over_argb32, argb32_source_argb32) to screen-ops.c, which is always compiled regardless of renderer choice.
Summary by cubic
Consolidated compositing primitive ops to make the built-in renderer self-contained and moved 3 essential screen ops to screen-ops.c so they’re always available across renderers. This cuts ~97.5% of unnecessary compositing code in PIXMAN mode and clearly separates renderer implementations.