Refine dependency checking with unified 'dep' #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="mk/deps.mk">
<violation number="1" location="mk/deps.mk:15">
The new `dep` macro suppresses error messages from dependency-checking tools by redirecting stderr to `/dev/null`. This system-wide change makes it significantly harder to diagnose missing dependencies, as it replaces clear error messages with silent failures that lead to more cryptic compiler or linker errors.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
This replaces all individual dependency macros with a single, concise interface: $(call dep,flag-type,package-name[s]) Where: - flag-type: cflags or libs - package-name[s]: Single package or space-separated list It also adds V=1 flag support to show pkg-config/config-tool errors. Usage: make # Silent mode (original behavior) make V=1 # Verbose mode (shows all dependency errors)
jserv
force-pushed
the
quiet-configure
branch
from
57a2bba to
ad4ecc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all individual dependency macros with a single, concise interface:
$(call dep,flag-type,package-name[s])
Where:
Summary by cubic
Unified dependency flag retrieval with a single dep make macro, replacing direct pkg-config and tool-specific calls. This simplifies the Makefile and supports multi-package flags with safer detection.