Fix errors raised by missing-prototypes #46
Conversation
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Improve git commit message!
|
Can I fix it like this? |
No, you must mention the considerations of upstream Linux changes that enforce function prototype checks, along with their impact on this project. Additionally, it is important to be aware of how to avoid missing function prototypes. |
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Mention upstream SHA-1 hash which enforce missing-prototypes checks.
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Make the git commit message grammatical accuracy.
The recent upstream commit (0fcb708) in the Linux kernel globally enforces function prototype checks. This means that it's crucial for each function to have a declaration to validate that both the caller and the callee expect the same argument types. Failure to comply with this requirement may result in real bugs due to mismatched prototypes. Therefore, in this commit, we need to add function prototypes to the header files or declare functions with static to ensure compatibility with these changes.
|
Thank @HotMercury for contributing! |
2 participants
In the current attempt to run simplefs on the Linux kernel v6.8 environment, encountering the error "no previous prototype for
simplefs_mount" indicates a need for additional function declarations.The reason why it worked in previous versions is that the changes related to
-Wmissing-declarationsand-Wmissing-prototypeswere introduced in 6.8-rc1 in commit 0fcb708 .