Skip to content

Conversation

@jason50123
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read https://cbea.ms/git-commit/ and make the git commit message informative.

@jserv jserv requested a review from RoyWFHuang May 3, 2024 15:11
Copy link
Collaborator

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to discuss the API changes across recent Linux kernel versions and ensure that simplefs is updated accordingly. The git commit message should be detailed and informative, rather than merely using "refine."

@jserv jserv changed the title Refine Linux 6.8 support Support Linux 6.8 May 6, 2024
Copy link
Collaborator

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the latest master branch.

To align with best practices recommended by Linux
kernel v6.8, this commit replaces direct accesses
to the __i_atime and __i_mtime fields with the
newly introduced accessor functions. The functions
used, such as inode_get_atime_sec and
simple_inode_init_ts, encapsulate direct
interactions with these inode fields. This change
not only enhances code readability and
maintainability but also ensures that the codebase
adheres to the evolving kernel API standards. This
approach minimizes direct manipulations of
internal structures, thereby reducing potential
for bugs and improving future compatibility with
kernel updates.
@jason50123 jason50123 requested a review from jserv May 6, 2024 09:06
@jserv jserv merged commit fcac769 into sysprog21:master May 6, 2024
@jserv
Copy link
Collaborator

jserv commented May 6, 2024

Thank @jason50123 for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants