Fix missing data synchronization #60
Merged
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
Collaborator
|
Can you improve the test suite to reflect the changes for data synchronization? |
Collaborator
Author
|
This means I need to improve my git message or add a test suite for GitHub Actions. |
Collaborator
Exactly. That is the reason why we deploy CI pipeline. |
jserv
reviewed
Jun 20, 2024
jserv
requested changes
Jun 20, 2024
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Improve the automated tests for checking the data consistency.
jserv
reviewed
Jun 20, 2024
The get_free_blocks function in simplefs has an issue where data written to the disk is not being properly synchronized. Testing: The test flow is as follow. After step 4 the content of test.txt is empty. 1. mount simplefs 2. vim test.txt 3. umount 4. mount Changes: Add sync_dirty_buffer to ensure proper disk synchronization. Add automated tests for checking the data consistency.
Collaborator
|
Thank @HotMercury for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_free_blocks function in simplefs has an issue where data written to the disk is not being properly synchronized.
Testing:
The test flow is as follow. After step 4 the content of test.txt is empty.
Change:
Add sync_dirty_buffer to ensure proper disk synchronization.