Always include vmalloc.h on all architectures #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 31, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Don't check in unrelated files.
Commit 5309792 ("Only include vmalloc.h on x86") limited the inclusion of <linux/vmalloc.h> to x86 architectures under the assumption that only x86 required it explicitly. However, <linux/vmalloc.h> is not architecture-specific, and other architectures may currently include it indirectly. To ensure consistency and future compatibility, include <linux/vmalloc.h> unconditionally to prevent build failures if indirect includes change in future kernel versions. Co-authored-by: Kuan-Wei Chiu <visitorckw@gmail.com> Co-authored-by: Chisheng Chen <johnny1001s000602@gmail.com>
Contributor
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 5309792 ("Only include vmalloc.h on x86", #6 ) attempted to limit the inclusion of
<linux/vmalloc.h>to x86 architectures, based on the assumption that only x86 requires it explicitly.However, this header is not architecture-specific, and other architectures may include it indirectly. For consistency and future proofing, it's safer to include
<linux/vmalloc.h>unconditionally, avoiding any potential build issues if indirect dependencies change.