Skip to content

fix builds for node 18+ #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix builds for node 18+ #1174

merged 2 commits into from
Sep 15, 2023

Conversation

@burden
Copy link
Contributor

@burden burden commented Sep 15, 2023 •
edited
Loading

tested:

  • v18.17.1
  • v20.6.1

@ahoneybun ahoneybun requested review from a team September 15, 2023 19:06
ahoneybun
ahoneybun approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the following so far:

  • Images load
  • Internal links work
  • Code blocks are good

macifell
macifell approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@macifell macifell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@burden burden merged commit 36248f3 into master Sep 15, 2023
@burden burden deleted the node18 branch September 15, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ahoneybun ahoneybun ahoneybun approved these changes

@macifell macifell macifell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@burden @ahoneybun @macifell