Skip to content

busctl: add a timestamp to the output of the busctl monitor command #17969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

busctl: add a timestamp to the output of the busctl monitor command #17969

merged 1 commit into from
Dec 15, 2020

Conversation

TrappM
Copy link
Contributor

@TrappM TrappM commented Dec 14, 2020

No description provided.

yuwata
yuwata requested changes Dec 14, 2020
View reviewed changes
@yuwata yuwata added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Dec 14, 2020
@TrappM TrappM force-pushed the busctl_timestamp branch 2 times, most recently from f19fc4f to f96f6d8 Compare December 14, 2020 14:39
yuwata
yuwata requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@yuwata yuwata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good for me. Several minor comments.

@TrappM TrappM force-pushed the busctl_timestamp branch 3 times, most recently from 729c784 to b00081c Compare December 14, 2020 16:26
@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Dec 14, 2020
@yuwata
Copy link
Member

yuwata commented Dec 14, 2020

LGTM.

@TrappM
Copy link
Contributor Author

TrappM commented Dec 14, 2020

LGTM.

thank you

poettering
poettering requested changes Dec 14, 2020
View reviewed changes
@poettering poettering added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed labels Dec 14, 2020
@yuwata
Copy link
Member

yuwata commented Dec 15, 2020

LGTM again ;-) But let's wait for @poettering's comment.

@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Dec 15, 2020
@poettering
Copy link
Member

lgtm

@yuwata yuwata merged commit 6fe2a70 into systemd:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuwata yuwata yuwata requested changes

@poettering poettering poettering requested changes

Assignees

No one assigned

Labels

busctl good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrappM @yuwata @poettering