hashmap: kill hashmap_free_with_destructor() and friends #37111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwata
changed the title
yuwata
force-pushed
the
hashmap-cleanup
branch
2 times, most recently
from
3195225 to
33ef0c8
Compare
This was referenced Apr 12, 2025
yuwata
changed the title
Member
Author
|
Continuation of #36107. |
yuwata
added
please-review
DaanDeMeyer
approved these changes
Apr 18, 2025
Collaborator
DaanDeMeyer
left a comment
DaanDeMeyer
left a comment
There was a problem hiding this comment.
Thank you so much for cleaning up the hashmap and set APIs! I never could figure out which one I was supposed to use, this will make it much clearer!
github-actions
bot
removed
the
please-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now destructor is always set in hash_ops when necessary. Hence, hashmap_free_with_destructor() and friends are not necessary anymore. Let's kill them.