Skip to content

Conversation

@mhalano
Copy link
Contributor

@mhalano mhalano commented Apr 18, 2025

Add G-Mode key, usually Fn+F9.

Closes #30824

@github-actions github-actions bot added hwdb please-review PR is ready for (re-)review by a maintainer labels Apr 18, 2025
@mhalano
Copy link
Contributor Author

mhalano commented Apr 18, 2025

I put prog2 as G-Mode since we already have a prog1 in place.
Please let me know if I should change this.

@yuwata yuwata merged commit ae04218 into systemd:main Apr 18, 2025
10 of 13 checks passed
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label Apr 18, 2025
@mhalano mhalano deleted the add-g-mode-key-hwdb branch April 18, 2025 09:53
@mhalano
Copy link
Contributor Author

mhalano commented Apr 18, 2025

@yuwata Thanks for approving my PR. What do you think in the future to change from prog2 to gmode? My idea is the performance mode beinge enabled when the user presses the key.

@yuwata
Copy link
Member

yuwata commented Apr 18, 2025

@yuwata Thanks for approving my PR. What do you think in the future to change from prog2 to gmode? My idea is the performance mode beinge enabled when the user presses the key.

OK if it works, but we usually use progX for such special keys. So, prog2 sounds also OK to me.

@mhalano
Copy link
Contributor Author

mhalano commented Apr 18, 2025

@yuwata Thanks for approving my PR. What do you think in the future to change from prog2 to gmode? My idea is the performance mode beinge enabled when the user presses the key.

OK if it works, but we usually use progX for such special keys. So, prog2 sounds also OK to me.

prog2 seems passed to X to open a program or something, but I have bigger plans: I want to find a way to turn on and off the power mode using this key, since it's what really does. On Linux, G-Mode is already enabled when I set performance mode, so the idea is doing this pressing a key. Stay tuned.

@yuwata
Copy link
Member

yuwata commented Apr 18, 2025

I am not familiar, but to change the power mode, a tiny program or script needs to be invoked when the key pressed? So, I still think prog2 is enough. No?

@mhalano
Copy link
Contributor Author

mhalano commented Apr 18, 2025

Yeah, but I would like to do lower level, probably as a quirk or something with systemd directly, to make this a usable feature, keeping prog* for things that user will touch over GUI.
But for now it was great. See you on my next issues and PRs. Have a great weekend.

@kuu-rt
Copy link
Contributor

kuu-rt commented May 8, 2025

Hi @mhalano,

This key (0x68) is also present on Alienware laptops and serves the same purpose. I submitted a similar PR that you can find here #37388.

There is one difference though, a release event has to be emulated. Hence why I mapped it to !prog3 instead of prog3. Isn't this the case for G-Series laptops too?

@mhalano
Copy link
Contributor Author

mhalano commented May 8, 2025

@kuu-rt thank you for your contribution. What would be a release event in this case? On my Dell G I just press the key and e test reports the scan code. How this is different on Alienware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

G-Mode key mapping on Dell G15 5515

3 participants