Remove SAVEQUERIES from the dynamicConstantNames list
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanDelMar
added a commit
to IanDelMar/phpstan-wordpress
that referenced
this pull request
Jul 7, 2025
This reverts commit 96deab8. It is handled separately in szepeviktor#287.
Owner
|
#172 What do you think @johnbillion ? |
johnbillion
approved these changes
Jul 7, 2025
Contributor
johnbillion
left a comment
johnbillion
left a comment
There was a problem hiding this comment.
Looks good. I think that means that WP_CLI should be removed too though.
Contributor
|
Oh Ian beat me to it with #288. |
Owner
|
I would leave it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
SAVEQUERIESconstant from thedynamicConstantNameslist inextension.neon, as it is not defined by WordPress (see this GitHub search).Including
SAVEQUERIESin thedynamicConstantNameslist prevents PHPStan from reporting the following code:If
SAVEQUERIESis not defined, this will trigger a fatal error in PHP 8+.