Doc updates for 1.10 #520
Doc updates for 1.10 #520
Conversation
docs/trex_getdata.md
Outdated
| let vizActiveSheet = viz.workbook.activeSheet; | ||
| if (vizActiveSheet.sheetType === "worksheet") { | ||
| const dataTableReader = await vizActiveSheet.getSummaryDataReaderAsync(); |
There was a problem hiding this comment.
Same as above. We don't have the viz.workbook.activiteSheet in extensions.
There was a problem hiding this comment.
I got rid of the viz.workbook.activeSheet, but forgot to remove the vizActiveSheet from the remaining line.
Done now.
There was a problem hiding this comment.
I don't think you have committed that yet. It still has the vizActiveSheet in my review.
There was a problem hiding this comment.
I guess I spoke too soon (before the commit/push). It should be good now.
88f444f
There was a problem hiding this comment.
Strange. That commit had a banner that said it wasn't connected to anything. I'm running this through a fork, which might be the problem. I did another push (git push upstream). That seems to have worked.
There was a problem hiding this comment.
I had one more commit to fix some formatting with a catch block.
2 participants
@johnDance @alicemhsiao @mwhagedorn @stephendeoca @bcantoni