npm audit: fix critical vulnerabilities #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump webpack
awful workflow while I figure out my two github accounts
from this breaking change in @types/node, a transitive dependency of the repo.
to avoid the deprecations in ts 5 that make another reason we should move off tslint
| "tslint": "^5.16.0", | ||
| "typescript": "^3.9.10", | ||
| "webpack": "5", | ||
| "typescript": "^4.9.0", |
Contributor
There was a problem hiding this comment.
The TS upgrade is a little worrisome. Do we have any assurance that everything is still working fine at runtime?
Contributor
Author
There was a problem hiding this comment.
It looks ok in AutoTest, and the 4.0 release notes say there are no breaking changes and updating should be invisible to the majority of projects.
anyoung-tableau
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm audit gives us:
found 17 vulnerabilities (7 moderate, 3 high, 7 critical) in 435 scanned packages
run
npm audit fixto fix 15 of them.1 vulnerability requires semver-major dependency updates.
1 vulnerability requires manual review. See the full report for details.
npm audit fix did:
fixed 15 of 17 vulnerabilities in 435 scanned packages
1 vulnerability required manual review and could not be updated
1 package update for 1 vulnerability involved breaking changes
The remaining vulnerability is a moderate level in tslint. TSLint has been deprecated since 2019 and was replaced by typescript-eslint.