fix(release): wrap hyperdb-compile-check pin in release-please markers#97
Merged
StefanSteiner merged 1 commit intoJun 2, 2026
Conversation
The optional `hyperdb-compile-check = "=0.3.1"` dependency in
hyperdb-api-derive/Cargo.toml was the only internal exact-version pin in
the workspace NOT wrapped in `# x-release-please-start-version` /
`# x-release-please-end` markers. release-please therefore bumped
hyperdb-compile-check's own version (and every other internal pin) to the
new release version but left this consumer pin at =0.3.1, making the
workspace unresolvable:
error: failed to select a version for the requirement
`hyperdb-compile-check = "=0.3.1"`
candidate versions found which didn't match: 0.4.0
required by package `hyperdb-api-derive`
This broke the v0.4.0 release-please PR (tableau#95): clippy, all three test
matrices, cargo-deny, publish-dry-run, and node-bindings all failed on
dependency resolution. Wrapping the pin lets release-please bump it in
lockstep with the rest of the workspace, as it already does for the
hyperdb-api dev-dependency pin a few lines below.
This was referenced Jun 1, 2026
Merged
StefanSteiner
added a commit
that referenced
this pull request
Jun 2, 2026
…allow-list (#98) The 'Verify lockfile diff is workspace-only' sentinel in release-please.yml builds its allow-list from `cargo metadata --no-deps` on the ROOT workspace. But hyperdb-compile-check is deliberately NOT a root-workspace member (it declares its own [workspace] so it can build/test standalone), so root metadata omits it — while it IS a path crate in the root lockfile and gets a 0.3.1 -> 0.4.0 bump during the release lock-sync. The guard therefore false-positived and aborted the v0.4.0 release with: Cargo.lock sync touched non-workspace packages: hyperdb-compile-check Fix: union the root workspace members with hyperdb-compile-check's own workspace members (its sub-workspace cargo metadata). Both halves are still derived at runtime, so future workspace additions stay in sync with no hard-coded list. Verified against the real v0.4.0 lock diff: the old allow-list flags hyperdb-compile-check (reproducing the failure); the unioned allow-list accepts all 9 bumped path crates and the guard passes. Also corrects the stale '8 workspace-member version rows' comment to 9, naming hyperdb-compile-check. This is the third place the compile-check non-membership exception needed handling (after the version-pin markers in #97 and the publish ordering).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional
hyperdb-compile-check = "=0.3.1"dependency in hyperdb-api-derive/Cargo.toml was the only internal exact-version pin in the workspace NOT wrapped in# x-release-please-start-version/# x-release-please-endmarkers. release-please therefore bumped hyperdb-compile-check's own version (and every other internal pin) to the new release version but left this consumer pin at =0.3.1, making the workspace unresolvable:This broke the v0.4.0 release-please PR (#95): clippy, all three test matrices, cargo-deny, publish-dry-run, and node-bindings all failed on dependency resolution. Wrapping the pin lets release-please bump it in lockstep with the rest of the workspace, as it already does for the hyperdb-api dev-dependency pin a few lines below.