Custom styles #61
Merged
Custom styles #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciminelli
previously approved these changes
Aug 4, 2023
ciminelli
reviewed
Aug 16, 2023
Member
ciminelli
left a comment
ciminelli
left a comment
There was a problem hiding this comment.
Can you customStyles to remove the -- prefix?
ciminelli
reviewed
Aug 16, 2023
js-sdk/src/index.stories.ts
Outdated
| "--color-input-background": "blanchedAlmond", | ||
| "--color-input-background-soft": "white", | ||
| "--color-background-menu-hover": "bisque", | ||
| "--color-green-ui": "darkGreen", |
Member
There was a problem hiding this comment.
@alotropico let's update color-green-ui to color-progress-bar
ciminelli
reviewed
Aug 16, 2023
js-sdk/src/index.stories.ts
Outdated
| "--color-background-modal": "blanchedAlmond", | ||
| "--color-text": "brown", | ||
| "--color-text-soft": "rgba(165, 42, 42, .5)", | ||
| "--importer-link": "indigo", |
Member
There was a problem hiding this comment.
@alotropico can you also update this to color-importer-link?
Collaborator
Author
There was a problem hiding this comment.
@ciminelli It can be done after this one is published tableflowhq/ui-library#7
# Conflicts: # importer-ui/src/components/Tooltip/index.tsx
ciminelli
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves TF-128