1-9-22 PR - Merge Global Preferences GUI back into main #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global preferences GUI elements created, need to write the saving procedure. NOT READY FOR PRIMETIME YET, WORK IN PROGRESS.
Wrote the saving mechanism and connected everything - all looks good, but want to run it through its paces!
Cleaned up a few stragglers, more testing on Windows. Looks good, going to test on MacOS now.
Don't save preferences file if there are no new preferences to save!
Resize all elements in global prefs to fill the space in the scrollbar horizontally. Also, added new version number.
- Made custom widget to "cancel" a keyboard shortcut registration (clicking on it resets it back to the "default" value) - A little bit more testing/cleaning up (set the shortcut keys to the "new" prefs values regardless, and *then* check them against the defaults - this way, if a button is reset to its default, the shortcut assignment gets correctly reassigned in the main program)
Changed the reset button from a button to a label, and changed some display parameters for that label.
Tested NLP on Linux (Ubuntu) and some text elements got cut off - so tweaked their geometry to size more properly on those systems. All looks good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the global preferences tab, along with options to set:
Preferences are saved to a file called NeewerLite-Python.prefs in the main directory