Incorrect paths being attributed to sections in generated output

[twelsh-aw]

First off, thanks for the tool. This is proving helpful to break things down and help us manage tailscale across networks and teams 🚀 .

Noticed that when multiple files are involved in a merge for an object or array property, that this ends up mis-attributing where the rules are actually sourced from.

Easiest repro is probably your testdata 😅:

tailscale-acl-combiner/testdata/output-file-to-compare-to.hujson

Line 6 in a9d8794

// from `testdata/input-parent.hujson`

when in fact they come from somewhere else. It should say:

// from `testdata/departments/engineering/acls.hujson`

The underlying cause seems to be because the parent object is updated throughout and so this comment gets added on the second merge of things.

Same thing is also able to cause panics on merges of autoApprovers, but I'll file a separate issue for that and link back here.

[clstokes]

Thanks for reporting. I really need to redo the commenting logic and maybe the merge-into-parent logic (😅) so this one might take me a bit longer to fix.

[clstokes]

@twelsh-aw I have a work-in-progress fix in #26 if you'd like to give it a try - e.g. go run github.com/tailscale-dev/tailscale-acl-combiner@b1e2d62.

I want to rework the test data and tests a bit more before merging it - hopefully in the next few days.

[twelsh-aw]

@clstokes beauty 🤩 . Will give it a spin later this week and let you know