-
Couldn't load subscription status.
- Fork 7
Add DisableFunction API #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -60,6 +60,11 @@ type DB interface { | |||||||||||||||
| // | ||||||||||||||||
| // If hook is nil, the hook is removed. | ||||||||||||||||
| SetWALHook(hook func(dbName string, pages int)) | ||||||||||||||||
| // DisableFunction disables an existing function (including built-ins) using | ||||||||||||||||
| // sqlite3_create_function. The name and numArgs must match the existing | ||||||||||||||||
| // function's signature. | ||||||||||||||||
| // | ||||||||||||||||
|
Comment on lines
+63
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor nit
Suggested change
It is probably also worth noting that we "disable" it by replacing that function name with a stub that does nothing, rather than making it report an error. That might be relevant to someone debugging. |
||||||||||||||||
| DisableFunction(name string, numArgs int) error | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| // Stmt is an sqlite3_stmt* database connection object. | ||||||||||||||||
|
|
||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, this will also let you "create" new previously non-existing no-op functions. That's harmless, but someone who misspells the function name they wanted to disable could easily be confused as there's no error to say "that doesn't exist".
Is it practical to look up the requested function first, and use that to report an error if someone tries to "disable" a function that isn't there? (E.g., we could query
select name, narg from pragma_function_list where name = 'fname'). That would also have the incidental benefit that we wouldn't need to know the argument count a priori.Not positive it's worth it, but this should be uncommon enough that it might be worth the extra step.