lower the msrv of sap to 1.85.0
#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert when rust-lang/rust#131114 is stable
imnotpoz
changed the title
core::str::from_utf8 instead of unstable str::from_utf8
Contributor
Author
|
I'll test various versions and add more changes to make this compatible later on |
Contributor
Author
|
this now compiles with rust |
Contributor
Author
|
also please squash when merging :3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR replaces
str::from_utf8(bytes)(rust-lang/rust#131114, still unstable) withcore::str::from_utf8(bytes)andOsStr::display(s)(rust-lang/rust#120048, stabilised in 1.87.0) withString::from_utf8_lossy(s.as_bytes()), pushing the msrv down to the earliest that supports the 2024 edition (1.85.0)there are comments next to each instance with the feature and link to its issue, as well as the old way it was done in case you want to go back to that