Skip to content

Metric Stream cost calculation#990

Merged
mlabouardy merged 5 commits intomlabouardy:developfrom
Azanul:aws-metric-stream-cost-calculation
Sep 26, 2023
Merged

Metric Stream cost calculation#990
mlabouardy merged 5 commits intomlabouardy:developfrom
Azanul:aws-metric-stream-cost-calculation

Conversation

@Azanul
Copy link
Copy Markdown
Collaborator

@Azanul Azanul commented Sep 23, 2023

Problem

Issue #878

Solution

metric stream cost = update cost * no. of updates

Fetching MetricUpdate cost using pricing API and update count using cloudwatch statistics API.

ref:

Changes Made

Notes

  • Ignored the AWS Kinesis Data Firehose surcharge

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy
@ShubhamPalriwala

Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Copy Markdown
Owner

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Azanul for the PR. I requested a small change before merging the PR :)

Comment thread providers/aws/cloudwatch/log_metrics.go Outdated
@mlabouardy mlabouardy added the aws label Sep 24, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 24, 2023
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul Azanul requested a review from mlabouardy September 24, 2023 16:32
Copy link
Copy Markdown
Owner

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy merged commit 42ba5f2 into mlabouardy:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Cost Calculation for AWS Cloudwatch Log Metrics

2 participants