Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include outline-color in default color properties to transition #10385

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

adamwathan
Copy link
Member

This PR updates the default transition and transition-colors classes to include the outline-color property. More important now than it has been historically since it follows the border radius in browsers nowadays and people are using outline for lots of things they might have used a border or box-shadow for in the past.

Co-Authored-By: Dilshod <28673719+deebov@users.noreply.github.com>
@rainerborene
Copy link

rainerborene commented Feb 12, 2023

I don't think this is a good default because @tailwindcss/forms includes outline properties on form elements which is causing this strange "border" animation:

Screencast.from.02-12-2023.01.41.56.PM.webm

You can test it by adding transition to input fields and also use @tailwindcss/forms.

@xt0rted
Copy link

xt0rted commented Feb 13, 2023

I just ran into the same issue as @rainerborene. Most, if not all, of my inputs had focus:outline-none and had to be switched to outline-none to stop the extra outline from showing. I had to do the same to some of my buttons since they were doing the same thing in some instances.

@zepfietje
Copy link

We're also running into this in the @filamentphp framework.
Users have started reporting this issue recently.

Any thoughts on reverting this change for now, @adamwathan?

@Quadrubo
Copy link

This issue also appears on a default Laravel Jetstream installation.

@thisisjamessmith
Copy link

thisisjamessmith commented Feb 15, 2023

I'd consider this a breaking change, personally. (Good idea though, I like it!)

adamwathan pushed a commit that referenced this pull request Feb 16, 2023
…rs` by default (#10604)

* Remove `outline-color` from default color properties to transition (Reverts #10385)

* Update changelog
adamwathan pushed a commit that referenced this pull request Feb 16, 2023
…rs` by default (#10604)

* Remove `outline-color` from default color properties to transition (Reverts #10385)

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants