Add first draft of new wide-gamut color palette #14693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
force-pushed
the
feat/p3-color-palette
branch
from
4a19e77 to
ca1e5e5
Compare
adamwathan
commented
Oct 16, 2024
Comment on lines
+628
to
+632
| @theme { | ||
| --color-red: rgb(255, 0, 0); | ||
| --color-green: rgb(0, 255, 0); | ||
| --color-blue: rgb(0, 0, 255); | ||
| } |
There was a problem hiding this comment.
Added these simple colors here so we have some stable colors to use in these UI tests, otherwise these tests are going to keep getting out of sync as we refine the color palette.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the colors in our default theme to use OKLCH instead of RGB and increases the overall chroma to take advantage of the wider color gamut.
Just a first draft based on @danhollick's initial work — expecting these will be further refined before a stable release as we continue to test them.