Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global variants not working when configs are merged #911

merged 1 commit into from May 13, 2019


Copy link

Fixes an issue where using a global variants config like variants: ['responsive', 'hover', 'focus'] wouldn't properly work because of some naive merging.

Since resolveConfig supports merging n configs (not just two) I'm not sure what should happen if someone tries to resolve three configs and the middle one uses the global array syntax but the other two don't. For now you will probably see unexpected behavior, but the common case is at least fixed where right now it's completely broken.

@adamwathan adamwathan merged commit fa17b48 into master May 13, 2019
@adamwathan adamwathan deleted the fix-global-variants branch May 13, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant