Code Standards: Use positions, not margins

[taitems]

Not particularly happy with the use of margins when we could be using absolute positioning.

[MarcusJT]

+1

[itkin]

+1

[worenga]

any benchmarks on the render performance of margins over position?

[taitems]

Sounds like a case for JSPerf :)

Sent from my iPhone

On 21/10/2012, at 11:20 PM, Benedikt Wolters notifications@github.com
wrote:

any benchmarks on the render performance of margins over position?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/13#issuecomment-9642094.

[taitems]

Interesting results in the JSPerf test here.

Position and margin are roughly equivalent, with translate3D being a breakaway winner when supported. No plans to implement that though. We'll be using left/top as margin values in this case are sloppy. Plus they're absolutely positioned anyway I believe.

[usmonster]

👍

[usmonster]

@taitems , can I just take this? It's literally a find-and-replace.. something like 4 lines would change. :]

Okay, maybe more than 4 lines, but it's a pretty straightforward refactor.

[taitems]

Please do.

Sent from my iPhone

On 17 Sep 2013, at 12:40 am, usmonster notifications@github.com wrote:

@taitems , can I just take this? It's literally a find-and-replace.. 4 lines would change. :]

—
Reply to this email directly or view it on GitHub.

[usmonster]

(Tacked the fix onto #93... I swear I'll stop with the ballooning pull requests after this one!)

[taitems]

Closed in #93

Performance diff is negligible. Translates are generally more performant but position has better support/compat.