Skip to content

Use more advanced Solhint rules (Fix #97) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Use more advanced Solhint rules (Fix #97) #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91b8b0d
issue 97 enable advanced solhint rule
susumutomita Nov 14, 2024
cdd3257
Add dummy private key
pmatsinopoulos Nov 21, 2024
6881c65
Another private key that doesn't look like a real one. Previous was d…
pmatsinopoulos Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

env:
FORCE_COLOR: true
PRIVATE_KEY: ${{secrets.PRIVATE_KEY}}
PRIVATE_KEY: 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'

steps:
- uses: actions/checkout@v2
Expand Down
17 changes: 16 additions & 1 deletion .solhint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
{
"extends": "solhint:default"
"extends": "solhint:recommended",
"rules": {
"func-visibility": [
"warn",
{
"ignoreConstructors": true
}
],
"var-name-mixedcase": "off",
"custom-errors": "off",
"no-global-import": "off",
"reason-string": "off",
"no-inline-assembly": "off",
"immutable-vars-naming": "off",
"one-contract-per-file": "off"
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"scripts": {
"build": "hardhat compile",
"test": "hardhat test",
"lint": "solhint contracts/**.sol && prettier --check contracts/**/*.sol",
"lint": "solhint contracts/**/*.sol && prettier --check contracts/**/*.sol",
"docgen": "solidity-docgen --solc-module solc-0.8.25 --templates=docgen/templates"
}
}
Loading