Skip to content

Conversation

@bugnano
Copy link
Collaborator

@bugnano bugnano commented May 9, 2022

No description provided.

@bugnano bugnano requested a review from vickz84259 May 9, 2022 14:08
@bugnano bugnano marked this pull request as ready for review May 23, 2022 08:01
Franco Bugnano and others added 6 commits May 23, 2022 15:54
Signed-off-by: Victor Omondi <victor@slick.co.ke>
The version with file upload support, talkjs_webview_flutter is now
available on pub.dev. These changes reflect that.

Signed-off-by: Victor Omondi <victor@slick.co.ke>
This permission is needed in order for the app to be able to access files.

Signed-off-by: Victor Omondi <victor@slick.co.ke>
This also adds the necessary entitlements for push notification support

Signed-off-by: Victor Omondi <victor@slick.co.ke>
Copy link
Collaborator

@vickz84259 vickz84259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are mostly about code organisation just for clarity purposes.

@bugnano bugnano requested a review from vickz84259 June 1, 2022 07:30
@bugnano bugnano force-pushed the feat/push-notifications branch from 1216fe7 to ded34ce Compare June 1, 2022 08:29
Copy link
Collaborator

@vickz84259 vickz84259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -0,0 +1,39 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this file from git. Anyone using this example app will need to generate their own version of it so it doesn't make sense to have it in version control

@vickz84259 vickz84259 merged commit 256b442 into main Jun 3, 2022
@vickz84259 vickz84259 deleted the feat/push-notifications branch June 3, 2022 15:30
@vickz84259 vickz84259 restored the feat/push-notifications branch June 6, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants