Skip to content

Conversation

@saschagrunert
Copy link
Member

Adding necessary meta information while referring to
kubernetes/org#1875

The contribution guidelines have been updated as well and now follow
https://github.com/kubernetes/kubernetes-template-project/blob/master/CONTRIBUTING.md

# INSTRUCTIONS AT https://kubernetes.io/security/

tallclair
kubernetes/enhancements-admins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be expanded too...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that this works via the OWNERS_ALIAS file too, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that this works via the OWNERS_ALIAS file too, right?

Yes and no...this file has no automation involved with it and is used "manually" by the Product Security Committee to see who should be contacted in case of a security concern. I guess they can infer from OWNERS_ALIASES themselves too though. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay thank you for the clarification 👍

@nikhita
Copy link
Member

nikhita commented May 15, 2020

@saschagrunert while we are here anyway, can you also add the "Community, discussion..." and "Code of conduct" sections to the README as per https://github.com/kubernetes/kubernetes-template-project#community-discussion-contribution-and-support? 🙏

Adding necessary meta information while referring to
kubernetes/org#1875

The contribution guidelines have been updated as well and now follow
https://github.com/kubernetes/kubernetes-template-project/blob/master/CONTRIBUTING.md

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

@saschagrunert while we are here anyway, can you also add the "Community, discussion..." and "Code of conduct" sections to the README as per https://github.com/kubernetes/kubernetes-template-project#community-discussion-contribution-and-support?

Done as well. Ready for another review round 👎

@nikhita
Copy link
Member

nikhita commented May 15, 2020

Lgtm from me 👍

@tallclair tallclair merged commit 068b50a into kubernetes-sigs:master Jun 26, 2020
@saschagrunert saschagrunert deleted the migrate branch June 26, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants