Skip to content

Escape/unescape $ in snippet substitutions (fixes #2015) #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2025
Merged

Escape/unescape $ in snippet substitutions (fixes #2015) #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7b5c28
Replace unnecessary regex use with str.replace.
nriley Sep 7, 2025
e5a8db1
Escape/unescape $ in snippet substitutions (fixes #2015).
nriley Sep 7, 2025
391cbd7
Merge branch 'main' into snippet-escaping
nriley Sep 13, 2025
4fd4412
Merge branch 'main' into snippet-escaping
nriley Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/snippets/snippets_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def compute_snippet_body_with_substitutions(
body = snippet.body
if substitutions:
for k, v in substitutions.items():
v = v.replace("$", r"\$")
reg = re.compile(rf"\${k}|\$\{{{k}\}}")
if not reg.search(body):
raise ValueError(
Expand Down
2 changes: 1 addition & 1 deletion core/snippets/snippets_insert_raw_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def format_tabs(text: str) -> str:
spaces_per_tab: int = settings.get("user.snippet_raw_text_spaces_per_tab")
if spaces_per_tab < 0:
return text
return re.sub(r"\t", " " * spaces_per_tab, text)
return text.replace("\t", " " * spaces_per_tab)


def parse_snippet(body: str):
Expand Down