feat(target): got the extra mile to find sdkroot

Author: kkharji

src/pbxproj/mod.rs

@@ -178,6 +178,48 @@ fn test_demo1_representation() {
     assert_eq!(None, root_group.path);
 }
 
+#[test]
+fn test_demo10_representation() {
+    let test_content = include_str!("../../tests/samples/demo10.pbxproj");
+    let project = PBXRootObject::try_from(test_content).unwrap();
+    let targets = project.targets();
+
+    assert_eq!(1, targets.len());
+    assert_eq!(&PBXTargetKind::Native, targets[0].kind);
+    assert_eq!(Some(&String::from("Scrumdinger")), targets[0].product_name);
+    assert_eq!(Some(&String::from("Scrumdinger")), targets[0].name);
+    assert!(!targets[0].sdkroots(project.objects()).is_empty());
+    assert_eq!(PBXProductType::Application, targets[0].product_type);
+    assert_eq!(None, targets[0].build_tool_path);
+    assert_eq!(None, targets[0].build_arguments_string);
+    assert_eq!(None, targets[0].build_working_directory);
+    assert_eq!(None, targets[0].pass_build_settings_in_environment);
+    assert_eq!(3, targets[0].build_phases.len());
+    assert_eq!(
+        vec![
+            (&PBXBuildPhaseKind::Sources, 11),
+            (&PBXBuildPhaseKind::Frameworks, 0),
+            (&PBXBuildPhaseKind::Resources, 4)
+        ],
+        targets[0]
+            .build_phases
+            .iter()
+            .map(|phase| (&phase.kind, phase.files.len()))
+            .collect::<Vec<_>>()
+    );
+
+    assert_eq!(1, project.projects().len());
+    let root_project = project.root_project();
+    println!("{:#?}", root_project.targets[0]);
+
+    let root_group = project.root_group();
+    assert_eq!(17, project.files().len());
+    // println!("{:#?}", root_group.children);
+    assert_eq!(5, root_group.children.len());
+    assert_eq!(None, root_group.name);
+    assert_eq!(None, root_group.path);
+}
+
 #[cfg(test)]
 macro_rules! test_demo_file {
     ($name:expr) => {{

src/pbxproj/object/collection.rs

@@ -58,7 +58,7 @@ impl PBXObjectCollection {
     /// Get vector by vector of T by predict
     pub fn get_vec_by<'a, T: AsPBXObject<'a> + 'a>(
         &'a self,
-        predict: fn(&(&String, &PBXHashMap)) -> bool,
+        predict: impl Fn(&(&String, &PBXHashMap)) -> bool,
     ) -> Vec<T> {
         self.iter()
             .filter(predict)
@@ -93,6 +93,15 @@ impl PBXObjectCollection {
         })
     }
 
+    /// Get all build phases
+    pub fn build_configurations<'a>(&'a self) -> Vec<PBXBuildPhase<'a>> {
+        self.get_vec_by(|(_, v)| {
+            v.get_kind("isa")
+                .map(|k| k.is_xc_build_configuration())
+                .unwrap_or_default()
+        })
+    }
+
     /// Get all build phases
     pub fn build_files<'a>(&'a self) -> Vec<PBXBuildFile<'a>> {
         self.get_vec_by(|(_, v)| {
@@ -226,6 +235,22 @@ impl PBXObjectCollection {
         })
     }
 
+    /// Get build configurations shearing a given baseConfiguration id
+    pub fn get_build_configurations_by_base_id<S: AsRef<str>>(
+        &self,
+        id: S,
+    ) -> Vec<XCBuildConfiguration> {
+        let key = id.as_ref();
+        self.get_vec_by(move |(_, v)| {
+            v.get_kind("isa")
+                .map(|o| o.is_xc_build_configuration())
+                .unwrap_or_default()
+                && v.get_string("baseConfigurationReference")
+                    .map(|s| s.as_str())
+                    == Some(key)
+        })
+    }
+
     /// Get XCSwiftPackageProductDependency by reference
     pub fn get_swift_package_product_dependency<'a>(
         &'a self,

src/pbxproj/object/target.rs

@@ -46,14 +46,31 @@ pub struct PBXTarget<'a> {
 
 impl<'a> PBXTarget<'a> {
     /// get target's sdk roots from all build configuration settings
-    pub fn sdkroots(&self) -> Vec<&String> {
+    pub fn sdkroots(&'a self, objects: &'a PBXObjectCollection) -> Vec<&'a String> {
         if let Some(ref bclist) = self.build_configuration_list {
-            bclist
+            let mut sdkroots = bclist
                 .build_configurations
                 .iter()
                 .flat_map(|b| b.build_settings.get_string("SDKROOT"))
-                .collect::<Vec<&String>>()
+                .collect::<Vec<&String>>();
+            if sdkroots.is_empty() {
+                // sdkroot isn't defined in current build settings.
+                // Here, we need to find all build configurations sharing
+                // the same base configuration id
+                bclist
+                    .build_configurations
+                    .iter()
+                    .flat_map(|b| Some(b.base_configuration.as_ref()?.id.as_str()))
+                    .flat_map(|id| objects.get_build_configurations_by_base_id(id))
+                    .flat_map(|b| b.build_settings.get_string("SDKROOT"))
+                    .for_each(|root| sdkroots.push(root));
+            }
+            if sdkroots.is_empty() {
+                tracing::error!("No SDKROOT found for {:?}", self.name);
+            }
+            sdkroots
         } else {
+            tracing::error!("No build configuration list for {:?}", self.name);
             Default::default()
         }
     }

tests/samples/demo1.pbxproj

@@ -158,7 +158,7 @@
 				LastUpgradeCheck = 1200;
 				TargetAttributes = {
 					0B66A7280B2FFE35D5F8E9A6 = {
-						DevelopmentTeam = 7N5BMV2F5G;
+						DevelopmentTeam = XXXXXXXXXX;
 					};
 				};
 			};
@@ -331,7 +331,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_IDENTITY = "iPhone Developer";
-				DEVELOPMENT_TEAM = 7N5BMV2F5G;
+				DEVELOPMENT_TEAM = XXXXXXXXXX;
 				DISABLE_MANUAL_TARGET_ORDER_BUILD_WARNING = YES;
 				INFOPLIST_FILE = Resources/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 15.0;
@@ -350,7 +350,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_IDENTITY = "iPhone Developer";
-				DEVELOPMENT_TEAM = 7N5BMV2F5G;
+				DEVELOPMENT_TEAM = XXXXXXXXXX;
 				DISABLE_MANUAL_TARGET_ORDER_BUILD_WARNING = YES;
 				INFOPLIST_FILE = Resources/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 15.0;