Using dataSource[dataKey] leads to false results #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `dataSource[dataKey]` has 2 issues:
1. It searches the complete prototype chain (which is unefficient)
2. If the resolved value is `0` or `false` the result is `false` (which isn't intended)
Example:
dataKey is 'id', it's value is zero:
e.g.
{
id: 0
}
So better to be explicit here, e.g. 👍
` if(dataSource.hasOwnProperty(dataKey)) `
Owner
|
Good suggestion, but you need fix eslint error. |
Contributor
Author
|
just fixed the linting error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
dataSource[dataKey]has 2 issues:0orfalsethe result isfalse(which isn't intended)Example:
dataKey is 'id', it's value is zero:
e.g.
{
id: 0
}
So better to be explicit here, e.g. 👍
if(dataSource.hasOwnProperty(dataKey))What kind of this PR? (check at least one)
Other information: