Skip to content
This repository was archived by the owner on Feb 19, 2021. It is now read-only.

Various fixes #4

Merged
t-b merged 2 commits into from
Aug 28, 2020
Merged

Various fixes #4

t-b merged 2 commits into from
Aug 28, 2020

Conversation

@t-b
Copy link
Contributor

@t-b t-b commented Aug 27, 2020

t-b added 2 commits August 27, 2020 18:53
@t-b
Makefile: Use a relative path which always exists for ACCESSCONTROL_HOME
7da3ffd
@t-b
TangoAccessControl.cpp: Remove dead code
5573c8b 
This was introduced in 804d832 (- Remove some compilation warnings when
compiled with Debian hardening flags - Add Debian hardening compilation
flags, 2012-02-07) to remove compiler warnings.

We don't want code here which does nothing so let's remove it.
@t-b
Copy link
Contributor Author

t-b commented Aug 27, 2020

@mliszcz @bourtemb I'm not powerful enough to merge or add you as reviewsers.

@t-b t-b mentioned this pull request Aug 27, 2020
Closed
@mliszcz
Copy link

mliszcz commented Aug 28, 2020

LGTM! But I am unable to approve or do any review in this repo.

bourtemb
bourtemb approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@bourtemb bourtemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourtemb
Copy link
Member

bourtemb commented Aug 28, 2020

@mliszcz @bourtemb I'm not powerful enough to merge or add you as reviewsers.

I added the cppTango team as admin for this repo too. You should have enough power to review & merge now I think.

@t-b t-b merged commit 45ed89b into tango-controls:master Aug 28, 2020
@t-b t-b deleted the various-fixes branch August 28, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bourtemb bourtemb bourtemb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-b @mliszcz @bourtemb