This repository was archived by the owner on Jul 8, 2022. It is now read-only.
tango_config.h: Add clang detection #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1] clang 3.3 has full C++11 support and 3.4 full C++14 support. So by requiring version 4 or higher we are on the safe side. [1]: https://clang.llvm.org/cxx_status.html
Collaborator
Author
|
I found that bug due to clang 6.0 complaining about deprecated auto_ptr which it should have never seen. |
Collaborator
Author
|
@bourtemb Any idea why the appveyor build failed? |
Member
Collaborator
Author
|
@bourtemb Thanks! So we are good to go here? |
Member
|
@t-b I think so... Let's merge this one! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 1 clang 3.3 has full C++11 support and 3.4 full C++14
support. So by requiring version 4 or higher we are on the safe side.