Skip to content

Optimize PolygonBuilder #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karimnaaji merged 2 commits into from
Nov 1, 2017
Merged

Optimize PolygonBuilder #72

karimnaaji merged 2 commits into from
Nov 1, 2017

Conversation

@matteblair
Copy link
Member

@matteblair matteblair commented Nov 1, 2017

  • Reduce coordinate data copying and iteration when generating data for Earcut
  • Remove index array reversal step

@matteblair matteblair requested a review from karimnaaji November 1, 2017 00:51
karimnaaji
karimnaaji approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@karimnaaji karimnaaji merged commit a9f87ef into master Nov 1, 2017
@karimnaaji karimnaaji deleted the optimize-builders branch November 1, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karimnaaji karimnaaji karimnaaji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matteblair @karimnaaji