-
-
Notifications
You must be signed in to change notification settings - Fork 398
perf: don't update on scroll/rect changes unless virtualized range changes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good! Can you rebase with the last 2 PRs that came in? |
Done! I also removed the |
Also remove the unnecessary `reversedMeasurements` array and `scrollOffsetPlusOuterSize` variable.
uonr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list doesn't corrently rendering when the parent containter wasn't mounted in the beginning.
Co-authored-by: coppa <dev@ioover.net>
|
@tannerlinsley This PR should be ready for another pass now 👍 |
|
Looks good! |
|
🎉 This PR is included in version 2.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@mogelbrod @tannerlinsley I think this change caused #68 and #56 because it attempts to interact with the parentRef element without checking whether it has been assigned (e.g. https://github.com/tannerlinsley/react-virtual/blob/master/src/index.js#L83) |
|
View your CI Pipeline Execution ↗ for commit 0cb45f0.
☁️ Nx Cloud last updated this comment at |
Fixes #46
useScroll()that doesn't cause the virtualized range to changereversedMeasurementsarray andscrollOffsetPlusOuterSizevariableuseScrollhook