Support partial results #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokshina
reviewed
Feb 12, 2021
dokshina
reviewed
Feb 12, 2021
olegrok
reviewed
Feb 12, 2021
Contributor
olegrok
left a comment
olegrok
left a comment
There was a problem hiding this comment.
Thanks for your patch! Consider several comments below.
dokshina
reviewed
Feb 15, 2021
mRrvz
reviewed
Feb 15, 2021
| {name = 'age', type = 'number'}, | ||
| }) | ||
| local objects = crud.unflatten_rows(result.rows, result.metadata) | ||
| t.assert_equals(objects, {{id = 1, name = 'Elizabeth', age = 24, bucket_id = 477}}) |
Contributor
There was a problem hiding this comment.
tarantool> vshard.router.bucket_id_strcrc32(1)
---
- 477
...
Contributor
There was a problem hiding this comment.
Okay, but maybe should do it like this?
t.assert_equals(objects, {{id = 1, name = 'Elizabeth', age = 24, bucket_id = vshard.router.bucket_id_strcrc32(1)}}) or maybe leave a comment on how 477 is formed
dokshina
reviewed
Feb 15, 2021
dokshina
reviewed
Feb 15, 2021
dokshina
reviewed
Feb 15, 2021
dokshina
reviewed
Feb 15, 2021
dokshina
reviewed
Feb 15, 2021
dokshina
reviewed
Feb 15, 2021
mRrvz
reviewed
Feb 16, 2021
dokshina
reviewed
Feb 18, 2021
dokshina
reviewed
Feb 18, 2021
AnaNek
force-pushed
the
support-partial-results
branch
from
ff28ef2 to
dab0848
Compare
olegrok
reviewed
Feb 18, 2021
dokshina
reviewed
Feb 19, 2021
Contributor
|
Thanks a lot for your patch! Me and @olegrok left two little comments. Please, also update CHANGELOG and describe new option in README and then we can merge this PR! |
dokshina
approved these changes
Feb 19, 2021
Contributor
dokshina
left a comment
dokshina
left a comment
There was a problem hiding this comment.
Thanks a lot for your patch!
olegrok
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116