-
Notifications
You must be signed in to change notification settings - Fork 15
Update function now adds intermediate nullable fields (if they needed) #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
olegrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you patch consider several comments below.
I've put quite a lot comments, so I need to clarify some expectations from this patch.
- Updates should be optimistic - we shouldn't get tuple before we understand that some field is missing: error has code
box.error.NO_SUCH_FIELD_NOorbox.error.NO_SUCH_FIELD_NAME - This logic should be performed on storage-side
- We should try to do it only for top-level fields (don't think about jsonpath updates)
- Tarantool allows to add fields after fields that declared in space format, but I think it's not general purpose case IMO - so we need to do something only if field name is in space format (but for some reasons some fields is missed before this field) or field number <= space format length.
olegrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fixes. Consider a couple of comments below.
dokshina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, consider my comments and update a Changelog.
olegrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes and fixes. Sorry for some controversial comments before.
Currently I basically agree with your patch and with your approach. I put some comments about some details. Please ask @dokshina for the second review.
dokshina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
cb996ba to
cde88ed
Compare
Fixed not fining field in tuple on
crud.updateif there areis_nullablefields in front of it that were added when the schema was changed. Closes #113