Skip to content

Conversation

@ligurio
Copy link
Member

@ligurio ligurio commented Aug 12, 2021

What has been done? Why? What problem is being solved?

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Closes #???

@ligurio ligurio changed the title Collect code coverage Collect code coverage data Aug 12, 2021
@ligurio ligurio force-pushed the ligurio/code_coverage branch 4 times, most recently from 1f20c8d to 2c87a99 Compare August 12, 2021 14:29
@olegrok
Copy link
Contributor

olegrok commented Aug 12, 2021

Is it possible to push results to coveralls?

Something like https://github.com/tarantool/graphql.0/blob/05f39946299cb2f35a97be326b992aace0205eaf/.travis.yml#L46

@ligurio ligurio force-pushed the ligurio/code_coverage branch 2 times, most recently from 5810297 to 289331b Compare August 12, 2021 16:16
@olegrok
Copy link
Contributor

olegrok commented Aug 12, 2021

Let's bump luatest version while we are here

@ligurio ligurio force-pushed the ligurio/code_coverage branch from d5b07f4 to 7bf53ff Compare August 12, 2021 19:10
@ligurio
Copy link
Member Author

ligurio commented Aug 12, 2021

Let's bump luatest version while we are here

bumped in a separate commit

@ligurio ligurio force-pushed the ligurio/code_coverage branch from 23a626e to 59f30e9 Compare August 12, 2021 20:52
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ligurio ligurio force-pushed the ligurio/code_coverage branch from 59f30e9 to a198ecc Compare August 12, 2021 21:41
When TARANTOOL_INSTALL_LUADIR is not defined CMake configuration
failed with error:

    CMake configuration failed with messages:

    CMake Error at CMakeLists.txt:17 (install):
      install DIRECTORY given no DESTINATION!

    CMake Error at CMakeLists.txt:22 (install):
      install FILES given no DESTINATION!

    CMake Error at CMakeLists.txt:27 (install):
      install DIRECTORY given no DESTINATION!

Added default value for TARANTOOL_INSTALL_LUADIR that fixes a problem.
@ligurio ligurio force-pushed the ligurio/code_coverage branch from a198ecc to 2ddf697 Compare August 12, 2021 21:52
@ligurio ligurio force-pushed the ligurio/code_coverage branch 8 times, most recently from 1d0755b to 23be327 Compare August 13, 2021 10:03
@ligurio ligurio force-pushed the ligurio/code_coverage branch 3 times, most recently from 23be327 to b6da111 Compare August 14, 2021 09:09
@ligurio ligurio force-pushed the ligurio/code_coverage branch from b6da111 to 8348d91 Compare August 14, 2021 21:41
luacov-coveralls allows to post code coverage data generated by luacov
to coveralls.io service [1] that has a nice UI to display covered and
uncovered code. We run regression tests for Tarantool CE and EE, however
source code of Tarantool EE is closed, so we send code coverage to
Coveralls for Tarantool CE only.

1. https://coveralls.io/github/tarantool/crud
@ligurio ligurio force-pushed the ligurio/code_coverage branch from 8348d91 to d1f83ea Compare August 14, 2021 21:43
@ligurio
Copy link
Member Author

ligurio commented Aug 14, 2021

Moved commit "Update Tarantool versions in test matrix" to a separate PR -
#198

@ligurio ligurio merged commit e8c05f1 into master Aug 14, 2021
@ligurio ligurio deleted the ligurio/code_coverage branch August 14, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants